Editable analysis prompts on the admin page
The system prompts of the free summary and the paid detailed analysis can be edited per language under /admin/promptok. Every save is a new row in prompt_revisions (NULL = built-in text); new analyses record the revision in prompt_version (v2-r<id>) and the worker uses exactly that text. Existing analyses stay; the cross-user cache only copies results of the same revision. The prompt code moves to the shared analysis-prompt crate so the backend can show the built-in text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012vLHzh5qUhFtmJhzkcTbXL
This commit is contained in:
@@ -827,3 +827,70 @@ async fn persons_use_package_slots(pool: PgPool) {
|
||||
let r = app.call("PATCH", &format!("/v1/charts/{pid}"), Some(&admin), Some(corrected)).await;
|
||||
assert_eq!(r.status, StatusCode::OK, "{}", r.body);
|
||||
}
|
||||
|
||||
#[sqlx::test(migrator = "db::MIGRATOR")]
|
||||
async fn admins_edit_analysis_prompts(pool: PgPool) {
|
||||
let app = TestApp::new(pool.clone()).await;
|
||||
let admin = app.register("admin@example.com", "Admin").await;
|
||||
let anna = app.register("anna@example.com", "Anna").await;
|
||||
assert_eq!(app.get("/v1/admin/prompts", Some(&anna)).await.status, StatusCode::FORBIDDEN);
|
||||
|
||||
let r = app.get("/v1/admin/prompts", Some(&admin)).await;
|
||||
assert_eq!(r.status, StatusCode::OK, "{}", r.body);
|
||||
let prompts = r.body["prompts"].as_array().unwrap();
|
||||
let keys: Vec<String> =
|
||||
prompts.iter().map(|p| format!("{}/{}", p["kind"], p["language"]).replace('"', "")).collect();
|
||||
assert_eq!(keys, ["summary/hu", "summary/en", "natal/hu", "natal/en"]);
|
||||
let natal = &prompts[2];
|
||||
assert_eq!((&natal["custom"], &natal["system"]), (&json!(false), &natal["default"]));
|
||||
assert!(natal["user_template"].as_str().unwrap().contains("{chart data}"));
|
||||
let default = natal["default"].as_str().unwrap().to_string();
|
||||
|
||||
let put = |body: Value, uri: &'static str| app.call("PUT", uri, Some(&admin), Some(body));
|
||||
assert_eq!(put(json!({"system": " "}), "/v1/admin/prompts/natal/hu").await.status, StatusCode::BAD_REQUEST);
|
||||
assert_eq!(put(json!({"system": "x"}), "/v1/admin/prompts/synastry/hu").await.status, StatusCode::NOT_FOUND);
|
||||
assert_eq!(put(json!({"system": "x"}), "/v1/admin/prompts/natal/de").await.status, StatusCode::NOT_FOUND);
|
||||
// saving the built-in text keeps the built-in prompt
|
||||
let r = put(json!({"system": default}), "/v1/admin/prompts/natal/hu").await;
|
||||
assert_eq!(
|
||||
(r.status, &r.body["custom"], r.body["history"].as_array().unwrap().len()),
|
||||
(StatusCode::OK, &json!(false), 0)
|
||||
);
|
||||
|
||||
// an analysis written with the built-in prompt
|
||||
let chart = app.chart(&anna, "Saját", true, "1990-03-15").await;
|
||||
let uri = format!("/v1/charts/{}/analyses", chart["id"].as_str().unwrap());
|
||||
grant_units(&app, &anna, "natal", 1).await;
|
||||
let r = app.call("POST", &uri, Some(&anna), None).await;
|
||||
assert_eq!((r.status, r.body["prompt_version"].as_str()), (StatusCode::ACCEPTED, Some("v1")));
|
||||
let first = r.body["id"].as_str().unwrap().to_string();
|
||||
sqlx::query("UPDATE analyses SET status = 'done', content = '{}', completed_at = now() WHERE id = $1::uuid")
|
||||
.bind(&first)
|
||||
.execute(&pool)
|
||||
.await
|
||||
.unwrap();
|
||||
|
||||
let r = put(json!({"system": "Saját szabályok.\r\n"}), "/v1/admin/prompts/natal/hu").await;
|
||||
assert_eq!(
|
||||
(&r.body["custom"], r.body["system"].as_str(), r.body["updated_by"].as_str()),
|
||||
(&json!(true), Some("Saját szabályok."), Some("admin@example.com"))
|
||||
);
|
||||
let revision = r.body["history"][0]["id"].as_i64().unwrap();
|
||||
let r = put(json!({"system": "Saját szabályok."}), "/v1/admin/prompts/natal/hu").await;
|
||||
assert_eq!(r.body["history"].as_array().unwrap().len(), 1); // unchanged: no new revision
|
||||
|
||||
// the chart keeps its analysis; the same birth data elsewhere is written anew with the edited prompt
|
||||
let r = app.call("POST", &uri, Some(&anna), None).await;
|
||||
assert_eq!((r.status, r.body["id"].as_str()), (StatusCode::OK, Some(first.as_str())));
|
||||
let bela = app.register("bela@example.com", "Béla").await;
|
||||
let same = app.chart(&bela, "Saját", true, "1990-03-15").await;
|
||||
grant_units(&app, &bela, "natal", 1).await;
|
||||
let r = app.call("POST", &format!("/v1/charts/{}/analyses", same["id"].as_str().unwrap()), Some(&bela), None).await;
|
||||
let expected = format!("v1-r{revision}");
|
||||
assert_eq!((r.status, r.body["prompt_version"].as_str()), (StatusCode::ACCEPTED, Some(expected.as_str())));
|
||||
|
||||
// back to the built-in prompt
|
||||
let r = put(json!({"system": null}), "/v1/admin/prompts/natal/hu").await;
|
||||
assert_eq!((&r.body["custom"], r.body["system"].as_str()), (&json!(false), Some(default.as_str())));
|
||||
assert_eq!(r.body["history"].as_array().unwrap().len(), 2);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user