From e530e78c542841717dbef5710b8859869e15fe1d Mon Sep 17 00:00:00 2001 From: feco Date: Fri, 20 Nov 2026 07:26:03 +0000 Subject: [PATCH] Stripe: company purchases, payment details kept for the invoice The checkout offers buying as a company (name, tax number). A confirmed payment keeps Stripe's payment id, the amount charged and the buyer's billing details, and queues the invoice for a background job (Billingo, once the company exists). Payments outlive a deleted account for the accounting law's 8 years. The package cards, the FAQ and the privacy policy say that card details go to Stripe only. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_012vLHzh5qUhFtmJhzkcTbXL --- .../db/migrations/0027_stripe_checkouts.sql | 35 +++++++-- docs/fizetes.md | 17 ++++- services/backend/src/routes/payments.rs | 75 ++++++++++++------- services/backend/src/stripe.rs | 12 +++ services/backend/src/tests.rs | 42 ++++++++++- .../frontend/src/app/adatvedelem/page.tsx | 18 ++++- services/frontend/src/app/csomagok/page.tsx | 4 + services/frontend/src/app/privacy/page.tsx | 15 +++- .../frontend/src/components/PackageCards.tsx | 6 +- services/frontend/src/lib/legal.ts | 4 +- 10 files changed, 180 insertions(+), 48 deletions(-) diff --git a/crates/db/migrations/0027_stripe_checkouts.sql b/crates/db/migrations/0027_stripe_checkouts.sql index f7d2114..40212d4 100644 --- a/crates/db/migrations/0027_stripe_checkouts.sql +++ b/crates/db/migrations/0027_stripe_checkouts.sql @@ -1,16 +1,35 @@ -- Stripe Checkout sessions started from the package cards. The package is -- granted once, when the payment is confirmed (webhook, or the return page -- asking Stripe), and the session id keeps that from happening twice. +-- Card details never reach us: only what Stripe reports about the payment and +-- the buyer's billing details for the invoice. CREATE TABLE stripe_checkouts ( -- Stripe's Checkout Session id (cs_test_… / cs_live_…). - id text PRIMARY KEY, - user_id uuid NOT NULL REFERENCES users ON DELETE CASCADE, - package text NOT NULL, - price_huf integer NOT NULL CHECK (price_huf > 0), - live boolean NOT NULL, - created_at timestamptz NOT NULL DEFAULT now(), - completed_at timestamptz, - order_id uuid REFERENCES package_orders ON DELETE SET NULL + id text PRIMARY KEY, + -- Kept when the account is deleted: payments and invoices must be kept + -- for the accounting law's 8 years. + user_id uuid REFERENCES users ON DELETE SET NULL, + package text NOT NULL, + price_huf integer NOT NULL CHECK (price_huf > 0), + live boolean NOT NULL, + created_at timestamptz NOT NULL DEFAULT now(), + -- Filled when the payment is confirmed. + completed_at timestamptz, + order_id uuid REFERENCES package_orders ON DELETE SET NULL, + payment_intent text, + -- What Stripe charged, in forints. + amount_huf integer, + -- Stripe's customer_details: name, e-mail, address, and for a company + -- its name and tax ids. + customer jsonb, + -- The invoice (a background job issues it): pending → issued, or failed + -- after retries (an admin looks at it). + invoice_status text CHECK (invoice_status IN ('pending', 'issued', 'failed')), + invoice_attempts integer NOT NULL DEFAULT 0, + invoice_error text, + invoice_number text, + invoiced_at timestamptz ); CREATE INDEX stripe_checkouts_user_idx ON stripe_checkouts (user_id, created_at DESC); +CREATE INDEX stripe_checkouts_invoice_idx ON stripe_checkouts (completed_at) WHERE invoice_status = 'pending'; diff --git a/docs/fizetes.md b/docs/fizetes.md index 33bbf3c..49dcf92 100644 --- a/docs/fizetes.md +++ b/docs/fizetes.md @@ -13,6 +13,21 @@ A csomagokat a Stripe Checkout fizetési oldalán lehet megvenni. A csomagok nev A session id miatt egy fizetés csak egyszer ír jóvá (`package_orders.source = 'stripe'`). +## Mit tárolunk + +Bankkártyaadatot soha: a vásárló a Stripe oldalán adja meg, hozzánk nem jut el. A `stripe_checkouts` sorban a fizetés igazolásakor eltároljuk: + +- a Stripe fizetés azonosítóját (`payment_intent`) és a ténylegesen fizetett összeget (`amount_huf`; ha eltér az ártól, hibát naplózunk), +- a vevő számlázási adatait (`customer`: a Stripe `customer_details` objektuma: név, e-mail, cím, céges vásárlásnál `business_name` és `tax_ids`, pl. `hu_tin` / `eu_vat`). + +A fizetési oldal kötelezően bekéri a számlázási címet, és felkínálja a céges vásárlást (cégnév, adószám; `tax_id_collection`). + +A sorok a fiók törlése után is megmaradnak (`user_id` → NULL), mert a számviteli törvény 8 évig megőrzést ír elő; ilyenkor csomag már nem jár, de a számla elkészül. + +## Számla + +Minden igazolt fizetés `invoice_status = 'pending'` állapotba kerül: ez a számlázási sor. A számlát egy háttérfeladat (worker) állítja ki a Billingo API-val, újrapróbálással (`invoice_attempts`, `invoice_error`), siker után `issued` + `invoice_number`, végleges hiba után `failed` (admin nézi meg). A Billingo-rész a cég és a Billingo-fiók után készül el; addig a sorok `pending` állapotban várnak. + ## Beállítás A kulcsok a `.env.secrets` fájlba kerülnek (helyben a repó gyökerében, a szerveren a `/opt/sorsfonalak` mappában), git-be soha: @@ -41,5 +56,5 @@ Helyben a webhook nem ér el a géphez; nem is kell, mert a visszatérő oldal a ## Megnyitás előtt - A Stripe-fiók aktiválása (céges adatok, bankszámla), élő kulcsok és élő webhook. -- Számla: Billingo API-val, minden sikeres fizetés után (a vásárló neve és címe a Checkoutból jön). A Stripe nyugtája nem magyar számla. +- Számla: a worker Billingo-feladata (lásd fent). A Stripe nyugtája nem magyar számla: a Stripe felületén a Customer emails → Successful payments legyen kikapcsolva. - Visszatérítés: egyelőre a Stripe felületén, a csomagot pedig az admin oldalon kell kézzel csökkenteni. diff --git a/services/backend/src/routes/payments.rs b/services/backend/src/routes/payments.rs index 4b85734..cfebe0a 100644 --- a/services/backend/src/routes/payments.rs +++ b/services/backend/src/routes/payments.rs @@ -134,8 +134,11 @@ pub async fn checkout( field("locale", "hu"), field("client_reference_id", &auth.id().to_string()), field("customer_email", &auth.user.email), - // Name and address go on the invoice. + // Name and address go on the invoice; a company also gives its name + // and tax number ("I'm buying as a business"). field("billing_address_collection", "required"), + field("tax_id_collection[enabled]", "true"), + field("customer_creation", "always"), field("line_items[0][quantity]", "1"), field("line_items[0][price_data][currency]", "huf"), // Stripe counts forints in fillér. @@ -163,29 +166,47 @@ pub async fn checkout( Ok(Json(json!({ "url": url }))) } -/// Grants the package of a paid session, once. `false`: not our session. -async fn complete(state: &AppState, session_id: &str) -> Result { +/// Records a paid session (what was charged, the buyer's billing details), +/// grants its package and queues the invoice, once. `false`: not our session. +async fn complete(state: &AppState, session: &stripe::Session) -> Result { let mut tx = state.db.begin().await?; - let row: Option<(Uuid, String, Option)> = - sqlx::query_as("SELECT user_id, package, completed_at FROM stripe_checkouts WHERE id = $1 FOR UPDATE") - .bind(session_id) - .fetch_optional(&mut *tx) - .await?; - let Some((user_id, package_id, completed_at)) = row else { return Ok(false) }; + let row: Option<(Option, String, i32, Option)> = sqlx::query_as( + "SELECT user_id, package, price_huf, completed_at FROM stripe_checkouts WHERE id = $1 FOR UPDATE", + ) + .bind(&session.id) + .fetch_optional(&mut *tx) + .await?; + let Some((user_id, package_id, price_huf, completed_at)) = row else { return Ok(false) }; if completed_at.is_some() { return Ok(true); } - let package = - packages::find(&package_id).ok_or_else(|| ApiError::Internal(format!("unknown package {package_id}")))?; - let note = format!("Stripe {session_id}"); - let order = packages::grant(&mut tx, user_id, package, Source::Stripe, Some(user_id), Some(¬e)).await?; - sqlx::query("UPDATE stripe_checkouts SET completed_at = now(), order_id = $2 WHERE id = $1") - .bind(session_id) - .bind(order) - .execute(&mut *tx) - .await?; + let amount_huf = session.amount_total.map(|minor| minor / 100); + if amount_huf != Some(i64::from(price_huf)) || session.currency.as_deref() != Some("huf") { + tracing::error!(session = %session.id, ?amount_huf, currency = ?session.currency, price_huf, "paid amount differs from the price"); + } + // A deleted account still gets its invoice, but no package. + let order = match user_id { + Some(user_id) => { + let package = packages::find(&package_id) + .ok_or_else(|| ApiError::Internal(format!("unknown package {package_id}")))?; + let note = format!("Stripe {}", session.id); + Some(packages::grant(&mut tx, user_id, package, Source::Stripe, Some(user_id), Some(¬e)).await?) + } + None => None, + }; + sqlx::query( + "UPDATE stripe_checkouts SET completed_at = now(), order_id = $2, payment_intent = $3, amount_huf = $4, \ + customer = $5, invoice_status = 'pending' WHERE id = $1", + ) + .bind(&session.id) + .bind(order) + .bind(&session.payment_intent) + .bind(amount_huf.map(|a| a as i32)) + .bind(&session.customer_details) + .execute(&mut *tx) + .await?; tx.commit().await?; - tracing::info!(user = %user_id, package = package.id, session = session_id, "package paid"); + tracing::info!(user = ?user_id, package = %package_id, session = %session.id, "package paid"); Ok(true) } @@ -207,7 +228,7 @@ pub async fn checkout_status( if let (None, Some(config)) = (completed_at, &state.config.stripe) { let session = state.stripe.get_session(config, &id).await?; if session.paid() { - complete(&state, &id).await?; + complete(&state, &session).await?; status = "paid"; } else if session.status.as_deref() == Some("expired") { status = "expired"; @@ -235,15 +256,13 @@ pub async fn stripe_webhook(State(state): St, headers: HeaderMap, body: Bytes) - tracing::warn!("stripe webhook with a bad signature"); return Err(ApiError::BadRequest("invalid signature".into())); } - let event: Value = serde_json::from_slice(&body).map_err(|e| ApiError::BadRequest(e.to_string()))?; + let mut event: Value = serde_json::from_slice(&body).map_err(|e| ApiError::BadRequest(e.to_string()))?; let kind = event["type"].as_str().unwrap_or_default(); - let session = &event["data"]["object"]; - if matches!(kind, "checkout.session.completed" | "checkout.session.async_payment_succeeded") - && session["payment_status"] == "paid" - { - let id = session["id"].as_str().unwrap_or_default(); - if !complete(&state, id).await? { - tracing::warn!(session = id, "stripe webhook for a session we did not start"); + if matches!(kind, "checkout.session.completed" | "checkout.session.async_payment_succeeded") { + let session: stripe::Session = serde_json::from_value(event["data"]["object"].take()) + .map_err(|e| ApiError::BadRequest(format!("checkout session: {e}")))?; + if session.paid() && !complete(&state, &session).await? { + tracing::warn!(session = %session.id, "stripe webhook for a session we did not start"); } } Ok(Json(json!({ "received": true }))) diff --git a/services/backend/src/stripe.rs b/services/backend/src/stripe.rs index 98f6439..8d27c9d 100644 --- a/services/backend/src/stripe.rs +++ b/services/backend/src/stripe.rs @@ -7,6 +7,7 @@ use std::time::Duration; use hmac::{Hmac, Mac}; use serde::Deserialize; +use serde_json::Value; use sha2::Sha256; use crate::config::StripeConfig; @@ -24,6 +25,17 @@ pub struct Session { pub payment_status: String, /// `open`, `complete` or `expired`. pub status: Option, + /// In the smallest unit (fillér for forints). + #[serde(default)] + pub amount_total: Option, + #[serde(default)] + pub currency: Option, + /// The PaymentIntent's id. + #[serde(default)] + pub payment_intent: Option, + /// Name, e-mail, billing address; for a company its name and tax ids. + #[serde(default)] + pub customer_details: Option, } impl Session { diff --git a/services/backend/src/tests.rs b/services/backend/src/tests.rs index 2017f13..04e526e 100644 --- a/services/backend/src/tests.rs +++ b/services/backend/src/tests.rs @@ -148,7 +148,10 @@ async fn fake_stripe_get(axum::extract::Path(id): axum::extract::Path) - StatusCode::OK, Json(json!({"id": id, "url": null, "payment_status": if *paid { "paid" } else { "unpaid" }, - "status": if *paid { "complete" } else { "open" }})), + "status": if *paid { "complete" } else { "open" }, + "amount_total": 200000, "currency": "huf", "payment_intent": "pi_fake", + "customer_details": {"name": "Anna Teszt", "email": "anna@example.com", + "address": {"city": "Szeged", "country": "HU"}, "tax_ids": []}})), ), None => (StatusCode::NOT_FOUND, Json(json!({"error": {"message": "no such session"}}))), } @@ -2301,6 +2304,8 @@ async fn stripe_checkout_grants_the_paid_package_once(pool: PgPool) { Some("Sorsfonalak – Páros") ); assert_eq!(stripe_form(&id, "customer_email").as_deref(), Some("anna@example.com")); + assert_eq!(stripe_form(&id, "tax_id_collection[enabled]").as_deref(), Some("true")); + assert_eq!(stripe_form(&id, "billing_address_collection").as_deref(), Some("required")); assert_eq!( stripe_form(&id, "success_url").as_deref(), Some("https://sorsfonalak.test/kepletek/abc?fizetes={CHECKOUT_SESSION_ID}") @@ -2327,7 +2332,12 @@ async fn stripe_checkout_grants_the_paid_package_once(pool: PgPool) { // The webhook: a bad signature is refused, a good one grants the package, // and Stripe's retries do not grant it again. let event = json!({"id": "evt_1", "type": "checkout.session.completed", - "data": {"object": {"id": id, "payment_status": "paid"}}}); + "data": {"object": {"id": id, "payment_status": "paid", "status": "complete", + "amount_total": 600000, "currency": "huf", "payment_intent": "pi_1", + "customer_details": {"name": "Kovács Anna", "email": "anna@example.com", + "business_name": "Csillag Kft.", + "address": {"line1": "Fő utca 1.", "city": "Szeged", "postal_code": "6720", "country": "HU"}, + "tax_ids": [{"type": "hu_tin", "value": "12345678-1-23"}]}}}}); let body = event.to_string(); let now = time::OffsetDateTime::now_utc().unix_timestamp(); let bad = crate::stripe::sign("whsec_other", body.as_bytes(), now); @@ -2344,6 +2354,17 @@ async fn stripe_checkout_grants_the_paid_package_once(pool: PgPool) { assert_eq!(r.status, StatusCode::OK, "{}", r.body); } assert_eq!(stripe_orders(&app.pool, "anna@example.com").await, vec![("couple".to_string(), 6000)]); + // What the invoice needs is kept, and the invoice is queued. + let (intent, amount, customer, invoice): (String, i32, Value, String) = sqlx::query_as( + "SELECT payment_intent, amount_huf, customer, invoice_status FROM stripe_checkouts WHERE id = $1", + ) + .bind(&id) + .fetch_one(&app.pool) + .await + .unwrap(); + assert_eq!((intent.as_str(), amount, invoice.as_str()), ("pi_1", 6000, "pending")); + assert_eq!(customer["tax_ids"][0]["value"], "12345678-1-23"); + assert_eq!(customer["address"]["postal_code"], "6720"); let r = app.get(&format!("/v1/payments/checkout/{id}"), Some(&anna)).await; assert_eq!(r.body["status"], "paid"); assert_eq!(r.body["name"], "Páros"); @@ -2367,6 +2388,23 @@ async fn stripe_checkout_grants_the_paid_package_once(pool: PgPool) { stripe_orders(&app.pool, "anna@example.com").await, vec![("couple".to_string(), 6000), ("single".to_string(), 2000)] ); + let (name, invoice): (String, String) = + sqlx::query_as("SELECT customer->>'name', invoice_status FROM stripe_checkouts WHERE id = $1") + .bind(&other) + .fetch_one(&app.pool) + .await + .unwrap(); + assert_eq!((name.as_str(), invoice.as_str()), ("Anna Teszt", "pending")); + + // Deleting the account keeps the payments (accounting law). + let r = app.call("DELETE", "/v1/me", Some(&anna), Some(json!({"confirm": "DELETE"}))).await; + assert!(r.status.is_success(), "{}", r.body); + let (kept,): (i64,) = + sqlx::query_as("SELECT count(*) FROM stripe_checkouts WHERE user_id IS NULL AND completed_at IS NOT NULL") + .fetch_one(&app.pool) + .await + .unwrap(); + assert_eq!(kept, 2); } #[sqlx::test(migrator = "db::MIGRATOR")] diff --git a/services/frontend/src/app/adatvedelem/page.tsx b/services/frontend/src/app/adatvedelem/page.tsx index 3b71040..6c399d3 100644 --- a/services/frontend/src/app/adatvedelem/page.tsx +++ b/services/frontend/src/app/adatvedelem/page.tsx @@ -86,6 +86,14 @@ export default async function PrivacyPage() { A megvásárolt szolgáltatás nyújtása, elszámolás Szerződés teljesítése; számviteli kötelezettség (6. cikk (1) c) + + + Fizetéseid adatai: a Stripe fizetési azonosítója, a fizetett összeg, a számlázási neved, címed és + e-mail-címed, céges vásárlásnál a cégnév és az adószám + + A fizetés igazolása, a számla kiállítása + Szerződés teljesítése; számviteli kötelezettség (6. cikk (1) c) + Meghívott e-mail-címe, a meghívó neve és személyes üzenete A meghívó elküldése; amíg az oldal zártkörű, csak meghívottak regisztrálhatnak @@ -110,8 +118,10 @@ export default async function PrivacyPage() {

- Bankkártyaadatot nem kezelünk és nem tárolunk; a fizetést, amikor elindul, külső fizetési szolgáltató - végzi, akinek a neve itt lesz feltüntetve. + Bankkártyaadatot nem kezelünk és nem tárolunk. A fizetés a Stripe biztonságos fizetési + oldalán történik: a kártyaadataidat közvetlenül a Stripe-nak adod meg, hozzánk nem jutnak el. A Stripe-tól + csak a fizetés azonosítóját, összegét és a számlázási adataidat kapjuk meg. Ezeket a fiókod törlése után is + megőrizzük a számviteli törvény szerinti ideig (8 évig).

@@ -198,6 +208,10 @@ export default async function PrivacyPage() { Amazon Web Services EMEA SARL (Amazon SES) – a rendszerlevelek és a meghívók kézbesítése; az Európai Unióban (Frankfurt). +
  • + Stripe Payments Europe, Ltd. (Írország) – a bankkártyás fizetés lebonyolítása és a + visszaélések kiszűrése; a kártyaadatokat csak a Stripe kezeli. +
  • OpenRouter, Inc. és az általa elért mesterségesintelligencia-szolgáltatók – az elemzések megírása, kizárólag a 4. pontban leírt csillagászati adatokból (személyes adat nem jut el hozzájuk). diff --git a/services/frontend/src/app/csomagok/page.tsx b/services/frontend/src/app/csomagok/page.tsx index dc42293..4a62180 100644 --- a/services/frontend/src/app/csomagok/page.tsx +++ b/services/frontend/src/app/csomagok/page.tsx @@ -10,6 +10,10 @@ import type { Package, PublicConfig } from "@/lib/types"; export const metadata: Metadata = { title: "Csomagok" }; const FAQ: [string, string][] = [ + [ + "Biztonságos a fizetés?", + "Igen. A fizetés a Stripe biztonságos fizetési oldalán történik, bankkártyával, Apple Payjel vagy Google Payjel. A kártyaadataidat közvetlenül a Stripe-nak adod meg: hozzánk nem jutnak el, és nem is tároljuk őket. Cégként is vásárolhatsz, ilyenkor a cégnevet és az adószámot is megadhatod a számlához.", + ], [ "Lejárnak a megvett elemzések?", "Nem. A csomagokban kapott elemzések és személyhelyek addig megmaradnak, amíg fel nem használod őket.", diff --git a/services/frontend/src/app/privacy/page.tsx b/services/frontend/src/app/privacy/page.tsx index 144af53..7571f0e 100644 --- a/services/frontend/src/app/privacy/page.tsx +++ b/services/frontend/src/app/privacy/page.tsx @@ -33,6 +33,11 @@ const DATA: [string, string, string][] = [ "Providing the purchased service, accounting", "Performance of a contract; legal obligation (Art. 6(1)(c))", ], + [ + "Your payments: Stripe's payment ID, the amount paid, your billing name, address and e-mail address, and for a company purchase the company name and tax number", + "Proof of payment, issuing the invoice", + "Performance of a contract; legal obligation (Art. 6(1)(c))", + ], [ "An invitee's e-mail address, the inviter's name and personal message", "Sending the invitation; while the site is invitation-only, only invitees can sign up", @@ -113,8 +118,10 @@ export default async function PrivacyPolicyPage() {

    - We do not process or store card details; payments, once available, will be handled by an external payment - provider, named here. + We do not process or store card details. Payments are made on Stripe's secure payment + page: you give your card details directly to Stripe, and they never reach us. From Stripe we only receive + the payment's ID, the amount and your billing details, which we keep for the period required by + accounting law (8 years), even after your account is deleted.

    @@ -200,6 +207,10 @@ export default async function PrivacyPolicyPage() { Amazon Web Services EMEA SARL (Amazon SES): delivering service e-mails and invitations; in the European Union (Frankfurt).
  • +
  • + Stripe Payments Europe, Ltd. (Ireland): processing card payments and preventing fraud; + only Stripe handles card details. +
  • OpenRouter, Inc. and the artificial intelligence providers it reaches: writing the readings, only from the astronomical data described in section 4 (no personal data reaches them). diff --git a/services/frontend/src/components/PackageCards.tsx b/services/frontend/src/components/PackageCards.tsx index 6017449..79c9720 100644 --- a/services/frontend/src/components/PackageCards.tsx +++ b/services/frontend/src/components/PackageCards.tsx @@ -149,10 +149,10 @@ export function PackageCards({

    )} {canPay === "mock" &&

    Tesztüzem: a fizetés még nincs bekötve, a gomb nem terhel semmit.

    } - {canPay === "stripe" && !compact && ( + {(canPay === "stripe" || canPay === "stripe_test") && (

    - A fizetés a Stripe biztonságos oldalán történik (bankkártya, Apple Pay, Google Pay); a kártyaadataidat mi nem - látjuk. + A fizetés a Stripe biztonságos oldalán történik (bankkártya, Apple Pay, + Google Pay). A kártyaadataidat közvetlenül a Stripe-nak adod meg: mi nem látjuk és nem tároljuk őket.

    )} {canPay === "stripe_test" && ( diff --git a/services/frontend/src/lib/legal.ts b/services/frontend/src/lib/legal.ts index daebda4..7d6119a 100644 --- a/services/frontend/src/lib/legal.ts +++ b/services/frontend/src/lib/legal.ts @@ -15,5 +15,5 @@ export function operatorDetails(): string | null { return parts.length > 0 ? parts.join(", ") : null; } -export const PRIVACY_UPDATED = "2026. november 19."; -export const PRIVACY_UPDATED_EN = "19 November 2026"; +export const PRIVACY_UPDATED = "2026. november 20."; +export const PRIVACY_UPDATED_EN = "20 November 2026";